Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made possible many examples to run in 512 bytes ram chips, fixed few … #141

Merged
merged 2 commits into from
Oct 20, 2015
Merged

Made possible many examples to run in 512 bytes ram chips, fixed few … #141

merged 2 commits into from
Oct 20, 2015

Conversation

fab672000
Copy link
Contributor

…typos, missing F() macro calls and other minor improvements
(Redid the changes from latest clone branch to ease merging).

@Avamander
Copy link
Member

@TMRh20 What should be done with this?

@TMRh20
Copy link
Member

TMRh20 commented Oct 11, 2015

Well, I should probably thank @fab672000 for making these changes, but I try to test everything mysef, at least minimally before pushing to the master branch.

The only question I have after visual review is regarding the need for the jamfile but was going to leave that for after.

Unfortunately, I haven't been able to do the testing, so the changes have just been sitting here waiting. As soon as I, you (or anybody) can do an 'official' run-through of the modified examples, and post confirmation that everything still compiles and works properly, they can be merged immediately. The new example looks good to me also.

@fab672000
Copy link
Contributor Author

Just to confirm I checked before submitting that all the changes do compile fine as far as I can remember.
Then, I also did test most of them if not all to be confident about all of these.
Please note that many changes repeat from one example to the other, changing only the title of the example being most of the difference. Also, in the worst case scenario of a regression, should a carriage return be missing or the like, it's quite easy to identify as opposed to the knowledge of the ram saving macro use or similar techniques imho.

Also I kept the existing Jamfile in examples because I was not sure if they are still used by some, but personally don't use them so feel free to trash them.

The most important changes are the one in the source code, not the makefiles use for which you would probably know better than i currently do.

These changes affecting directly the RAM utilization are the significant improvement to capture here.
I also fixed some missing macros that were forgotten last time you or someone else in that branch started to do similar changes, hope it helps having a 100% clean status on ram use in the examples now.

Finally please note that code can be much more improved for one example there where i decided to not optimize it because of lack of time for testing.

The change is trivial though and I'll come back to it in my leisure time as soon as i can test it.

Avamander added a commit that referenced this pull request Oct 20, 2015
Reduced RAM usage, added a new example, fixed inconsistencies.
@Avamander Avamander merged commit 46ccceb into nRF24:master Oct 20, 2015
@Avamander
Copy link
Member

I tested the changed files, all compiled fine. (I did not test the Jamfile file)

@fab672000 Thanks!

@fab672000
Copy link
Contributor Author

NP, I'm glad I could humbly help ; thanks to both of you for doing such a great job on that fork !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants