Fix wireguard interface creation on localized windows #2451

tadaskay · 2020-07-09T11:16:56Z

Fixes: #2443
Fixes: #2450

The root cause was:

Gateway detection fails due to Will not working on windows of non-Englisht language jackpal/gateway#19 (fixed in the latest version)
Cleanup upon failed initialization is not performed (Wireguard not cleaning up on failed initialization (supervisor) #2450).
As a result, the wireguard socket is busy and any further tries result in an access denied error.

tadaskay requested review from anjmao, soffokl, vkuznecovas, Waldz and zolia as code owners July 9, 2020 11:16

chompomonim approved these changes Jul 10, 2020

View reviewed changes

vkuznecovas approved these changes Jul 10, 2020

View reviewed changes

Waldz approved these changes Jul 10, 2020

View reviewed changes

tadaskay added 5 commits July 10, 2020 12:07

Improve logging levels for supervisor

2b548a4

Make supervisor depend on windows network services

cc6287d

Merge macOS and windows wg interface; properly cleanup

bf0a02b

Fix gateway detection on localized windows versions

c54e2f2

Add linux placeholders for wireguard interface (supervisor)

050756b

tadaskay force-pushed the 2450-wg-cleanup-on-failed-init branch from 01f9c51 to 050756b Compare July 10, 2020 09:07

tadaskay merged commit b726950 into master Jul 10, 2020

tadaskay deleted the 2450-wg-cleanup-on-failed-init branch July 10, 2020 10:04

Provide feedback