-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build supervisor with xgo #2318
Conversation
81ab26e
to
b12d52f
Compare
17fa03b
to
67f36b6
Compare
We are already crosscompiling and we don't need xgo for the supervisor. The proper way would be to use a separate go.mod for that sub-project instead of trying to work around go-ethereum quirks (which supervisor does not need at all). |
ee31fbf
to
2dac05d
Compare
I'm with Tadas on this one. If we use XGO it's going to prolong our build times by quite a lot. |
2dac05d
to
624e523
Compare
624e523
to
a796c86
Compare
We are using xgo for building node atm anyways. I agree that we should migrate to cgo, but there is problem with go-ethereum - again. I suggest to follow this PR to be approved: ethereum/go-ethereum#21041 and bump etherium dependency then. For now I suggest to merge as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to fix it, please don't merge
0bcaab3
to
8360edc
Compare
8360edc
to
f299853
Compare
f299853
to
2224d34
Compare
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
+ Coverage 48.06% 48.11% +0.05%
==========================================
Files 281 281
Lines 12989 12989
==========================================
+ Hits 6243 6250 +7
+ Misses 6147 6140 -7
Partials 599 599
Continue to review full report at Codecov.
|
fixed by 924532c and do not depend on go-ethereum in supervisor. Closing this PR since major refactoring is needed here and best to move to mage format in order to eliminate excessive duplications. |
should fix #2314
Packaging on MacOS is running fine, thats why we missed probably.
We prob need to cross compile anyways.