Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BackgroundConnectionResetHelper (used by DeferConnectionReset=false) #1013

Closed
bgrainger opened this issue Jul 5, 2021 · 0 comments
Closed

Remove BackgroundConnectionResetHelper (used by DeferConnectionReset=false) #1013

bgrainger opened this issue Jul 5, 2021 · 0 comments
Milestone
2.0

Comments

@bgrainger
Copy link
Member

bgrainger commented Jul 5, 2021 •
edited
Loading

BackgroundConnectionResetHelper (used when DeferConnectionReset = false, the default from 1.3.0 to 1.3.9 inclusive) appears to be the source of a number of bugs/deadlocks:

Its initial implementation added a lot of extra latency: #982

It was disabled by default in c4d66c0.

Remove the code (and ignore the connection string option) until a more robust implementation can be developed.
This was referenced Jul 5, 2021
Closed
Closed
Closed
bgrainger added a commit that referenced this issue Jul 5, 2021
@bgrainger
Remove BackgroundConnectionResetHelper. Fixes #1013
8ad72a1
@bgrainger bgrainger changed the title Remove BackgroundConnectionResetHelper Remove BackgroundConnectionResetHelper (used by DeferConnectionReset=true) Jul 9, 2021
@bgrainger bgrainger changed the title Remove BackgroundConnectionResetHelper (used by DeferConnectionReset=true) Remove BackgroundConnectionResetHelper (used by DeferConnectionReset=false) Jul 9, 2021
@bgrainger bgrainger added this to the 2.0 milestone Oct 16, 2021
@bgrainger bgrainger mentioned this issue Mar 18, 2022
Open
@bgrainger bgrainger mentioned this issue Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@bgrainger