[Admin] Move add body/category forms to own pages, limit history #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5140 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 404 404
Lines 31515 31526 +11
Branches 4995 5000 +5
==========================================
+ Hits 26047 26055 +8
- Misses 3985 3987 +2
- Partials 1483 1484 +1 ☔ View full report in Codecov by Sentry. |
dracos
requested review from
neprune,
davea and
chrismytton
and removed request for
neprune and
davea
chrismytton
approved these changes
Aug 29, 2024
This simplifies the code - as the edit controller was handling body edit, unconfirmed-confirming, and new categories - and improves the interface (a body page doesn't have two entirely different forms at the bottom any more).
dracos
force-pushed
the
admin-sidebar-body
branch
from
df914c5 to
c991bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One very old 'bug', in that we can now view those pages (and then separately deal with whatever is creating 1000s of log entries), and then I was fed up of being confused by two forms on one page.