Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bazelversion to 8 #94

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bump bazelversion to 8 #94

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
867a677
Bump bazelversion to 8
hofbi Dec 20, 2024
02b01a9
try to fix ci
hofbi Feb 6, 2025
07b9590
add more details for new flag
hofbi Feb 10, 2025
0ce7b5b
add more details for new flag
hofbi Feb 10, 2025
171fd78
Merge branch 'main' into bump-bazel-8
hofbi Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ build --nolegacy_external_runfiles
# Don't bother building targets which aren't dependencies of the tests.
test --build_tests_only

# Default changed in bazel 8
# See: https://github.com/bazelbuild/bazel/commit/489d08bf472f4568b3f7f478a8747a30cb956111
build --zip_undeclared_test_outputs=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the easy solution to make it work with bazel 8. Getting rid of this flag might require some changes in the rostest impl of this repo.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks for digging into this. Do you know what changes are needed?

Copy link
Contributor Author

@hofbi hofbi Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't dig deeper into the problem. But with the new default from Bazel 8, you would have a directory structure instead of a .zip file in some test output folder. Any immediate idea where this could be problematic?


# Load any settings specific to the current user.
# user.bazelrc should appear in .gitignore so that settings are not shared with
# team members. This needs to be last statement in this config,
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.4.1
8.0.1