group all standard library imports

[sonatard]

import (
	"github.com/b/xxxx"
	"context"

	"time"

	"github.com/a/xxx"
)

I hope following code after gofumports.

import (
	"context"
	"time"

	"github.com/a/xxx"
	"github.com/b/xxxx"
)

[mvdan]

Looks like this is being implemented in golang/go#20818. Since it's planned there, and since implementing this would be non-trivial, let's wait and see how that issue progresses.

[mvdan]

Hmm, if I do this only for standard library imports, that might be simple enough to implement on our side.

[mvdan]

I took a shot at this yesterday, but it's a nightmare to implement properly while keeping good position information. That is, without messing up empty lines or comments.

[sonatard]

I think gofumports only delete empty lines in imports. exec goimports after gofumports.

1. gofumpotrs delete empty lines.

import (
	"github.com/b/xxxx"
	"context"

	"time"

	"github.com/a/xxx"
)

import (
	"github.com/b/xxxx"
	"context"
	"time"
	"github.com/a/xxx"
)

2. Exec goimports

import (
	"context"
	"time"

	"github.com/a/xxx"
	"github.com/b/xxxx"
)

[mvdan]

While that's an interesting idea, it wouldn't work; we'd also be clumping together non-std imports. For example, a common standard is to group together third-party imports by project or by purpose.

[mvdan]

The heuristic here was a bit lax; I've made it a bit more aggressive. See the commit pushed to master just above.