fix: revert theme render flicker (breakpoints) #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mmcc
approved these changes
Jan 22, 2025
luwes
force-pushed
the
theme-visibility
branch
from
cca3a3a to
2b00da2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
- Coverage 78.55% 77.48% -1.07%
==========================================
Files 59 51 -8
Lines 11080 12313 +1233
Branches 0 722 +722
==========================================
+ Hits 8704 9541 +837
- Misses 2376 2744 +368
- Partials 0 28 +28 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 29, 2025
luwes
added a commit
to muxinc/elements
that referenced
this pull request
Feb 13, 2025
related muxinc/media-chrome#1055 this should fix the flicker that could happen between showing the thumbnail and showing the whole theme w/ thumbnail. - [x] todo: double check removing that hide not defined CSS doesn't cause glitches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #960
from feedback via next-video we heard there is a split second empty flicker now when using a slotted poster image.
first the blurhash appears, after the thumbnail then nothing (seeing background of page), then the poster and player UI.
the reason is that the theme visibility is hidden until the breakpoints are available.
after reconsideration this solution doesn't feel like the correct way to handle this.
better is to be more precise in the theme itself and require breakpoints to render any control variants.
this will require some changes in some themes where we don't default to the smallest size variant for example but still require a small breakpoint width. could be even zero.