Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: changing playback ID results in old storyboard still loaded for timeline hover preivew #936

Closed
1 task done
dylanjha opened this issue Jun 10, 2024 · 0 comments · Fixed by muxinc/media-elements#49 or #1021
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@dylanjha
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player

Which browsers are you using?

Chrome

Which operating systems are you using?

None

Description

When changing the playback-id, the player still has the old timeline hover previews loaded.

I can workaround this by setting muxPlayer.playbackId = null before changing

Reduced test case

https://codesandbox.io/p/sandbox/mux-player-bug-reset-playback-id-fs95rn?file=/src/index.js:8,36

Steps to reproduce

  1. Click play, see timeline hover preview
  2. Click pause
  3. Click "change playback ID"

Current Behavior

See timeline hover preview has the old storyboard

Expected Behavior

Timeline hover preview should have the new storyboard

Errors

No response

What version of the package are you using?

v2.7

@dylanjha dylanjha added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Jun 10, 2024
@luwes luwes removed the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Nov 6, 2024
@luwes luwes self-assigned this Nov 21, 2024
luwes added a commit to luwes/elements that referenced this issue Nov 26, 2024
luwes added a commit to luwes/elements that referenced this issue Nov 26, 2024
luwes added a commit that referenced this issue Nov 26, 2024
fix #936

1. go to
https://elements-demo-vanilla-git-fork-luwes-fix-load-tracks-mux.vercel.app/mux-player.html
2. hit play button
3. view storyboard by hovering over timeline
4. press load new playback id button
5. hit play button
6. check that storyboard was updated to new video
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants