Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify parameters for buildings addons #70

Merged
merged 5 commits into from
Mar 25, 2024
Merged

unify parameters for buildings addons #70

merged 5 commits into from
Mar 25, 2024

Conversation

juleshaas
Copy link
Contributor

@juleshaas juleshaas commented Mar 21, 2024

MR unifys parameters for the buildings addons (m.analyse.buildings), especially it:

  • labels parameters as required
  • uses parser standard options
  • renames parameters, options etc. to English
  • adapts/unifys label text
  • reorders some parameters
  • sets default values for required parameters
    • if output is previously set to default, then this value is set as input in next addon -> note: if output is named differently by the user, then default input must also be adjusted for the next module

@juleshaas juleshaas changed the title Draft: unify parameters for buildings addons unify parameters for buildings addons Mar 22, 2024
Copy link
Contributor

@linakrisztian linakrisztian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some remarks, but overall looks good to me, thanks:)

@juleshaas juleshaas merged commit a1f7d39 into main Mar 25, 2024
7 checks passed
@juleshaas juleshaas deleted the unify_parameters branch March 25, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants