Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel DSM and nDSM #32

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Parallel DSM and nDSM #32

merged 4 commits into from
Feb 10, 2023

Conversation

anikaweinmann
Copy link
Member

  • parallel import od DSM and parallel computation of nDSM
  • Vector import with snap=0.001

metzm
metzm reviewed Feb 9, 2023
View reviewed changes
grass-gis-addons/m.import.rvr/m.import.rvr.py Outdated
"resolution": res,
"type": "FCELL",
"method": "percentile",
"pth": 5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below the comments say generate 95%-max DSM thus rather "pth": 95, ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metzm yes you are right. I have taken it from Guidos script https://github.com/mundialis/rvr_interface/blob/main/scripts/import_laz_vrt.sh#L51-L52, so what sould we use for the import 95 make more sense than 5 or what do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that using the 95th percentile makes more sense to get the heights of buildings and trees. Could be a simple typo in the script?

@anikaweinmann anikaweinmann merged commit 7fc3cd7 into main Feb 10, 2023
@juleshaas juleshaas deleted the parallel_dsm_and_ndsm branch February 13, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler left review comments

@metzm metzm metzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anikaweinmann @neteler @metzm