Only use lint when generating a new verification metadata file #7813
+2
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
requested changes
Mar 13, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
android/scripts/update-lockfile.sh line 20 at r1 (raw file):
"assemble" "compileDebugUnitTestKotlin" "assembleAndroidTest"
Still necessary? Otherwise we can change to an empty list
Code quote:
"-xcargoBuild"
Pururun
force-pushed
the
only-use-lint-for-verification-script
branch
2 times, most recently
from
e7f1d4c to
590a603
Compare
albin-mullvad
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
force-pushed
the
only-use-lint-for-verification-script
branch
2 times, most recently
from
feaaf09 to
53fa003
Compare
Also remove excluded cargo task as it is no longer needed
Pururun
force-pushed
the
only-use-lint-for-verification-script
branch
from
53fa003 to
0da3da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is