-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mullvad-cli
panicking if writing to a closed pipe
#7802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
mullvad-cli/src/main.rs
line 159 at r1 (raw file):
// https://github.com/rust-lang/rust/issues/119980 // https://github.com/typst/typst/pull/5444 sigpipe::reset();
I would slightly prefer using libc over another dependency here.
da14299
to
a202abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @dlon)
mullvad-cli/src/main.rs
line 159 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
I would slightly prefer using libc over another dependency here.
Done WDYT?
beabe72
to
ec9f3b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
mullvad-cli/src/main.rs
line 159 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Done WDYT?
ec9f3b4
to
68fc980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Fix `SIGPIPE` being ignored, which would cause the `mullvad-cli` to panic if it received a `PIPE` signal (e.g. it was piped into `echo`).
68fc980
to
54e0bea
Compare
This PR fixes #7689. I've provided sources to the problem and suggested solution as comments in the code. Please have a look.
This change is