Improve TV connect screen UI #7795
Conversation
- Implements the navigation rail design for Android TV
- Implements the TV notification banner design
- Adds two new Gradle modules:
* tv: contains the Android TV specific Compose components (e.g. the
NavigationDrawerTV component)
* shared-compose: contains Compose-specific code that is needed by
both the app module and the tv module.
There was a problem hiding this comment.
Reviewed 48 of 48 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions
android/settings.gradle.kts line 26 at r1 (raw file):
":lib:resource", ":lib:shared", ":lib:shared-compose",
Let's talk about this name internally, I think we should align it how it fits in our gradle module restructuring.
android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/InAppNotification.kt line 1 at r1 (raw file):
package net.mullvad.mullvadvpn.lib.shared
Should probably not be in shared but rather the lib/model
android/lib/shared-compose/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/compose/test/ComposeTestTagConstants.kt line 1 at r1 (raw file):
package net.mullvad.mullvadvpn.lib.shared.compose.test
Not sure where we want these testTags to live, both test and code use them. They are the worst, let's discuss internally when we talk about the rest of the modules.
android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/VersionInfo.kt line 1 at r1 (raw file):
package net.mullvad.mullvadvpn.lib.shared
Possibly should be in domain (depending if it makes sense, it is more part of a repository thing it may still live here)
There was a problem hiding this comment.
Reviewable status: 47 of 49 files reviewed, 4 unresolved discussions (waiting on @Rawa)
android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/InAppNotification.kt line 1 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Should probably not be in shared but rather the
lib/model
Done.
android/lib/shared/src/main/kotlin/net/mullvad/mullvadvpn/lib/shared/VersionInfo.kt line 1 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Possibly should be in domain (depending if it makes sense, it is more part of a repository thing it may still live here)
Done.
This change is