Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Any" tunnel protocol from query builder #7792

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

Serock3
Copy link
Contributor

@Serock3 Serock3 commented Mar 10, 2025


This change is Reviewable

@Serock3 Serock3 added the Daemon Issues related to mullvad-daemon label Mar 10, 2025
@Serock3 Serock3 self-assigned this Mar 10, 2025
@Serock3 Serock3 force-pushed the remove-relay-query-builder-any-protocol branch from ed2142f to 3aaf181 Compare March 10, 2025 16:34
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion


mullvad-relay-selector/src/relay_selector/query.rs line 618 at r1 (raw file):

    //         Self::new()
    //     }
    // }

Remove this code imho

Code quote:

    // impl Default for RelayQueryBuilder<Any> {
    //     fn default() -> Self {
    //         Self::new()
    //     }
    // }

@Serock3 Serock3 force-pushed the remove-relay-query-builder-any-protocol branch 2 times, most recently from 84cea87 to 29dacc6 Compare March 11, 2025 15:19
Copy link
Contributor Author

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


mullvad-relay-selector/src/relay_selector/query.rs line 618 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Remove this code imho

Whoops

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Serock3 Serock3 force-pushed the remove-relay-query-builder-any-protocol branch from 29dacc6 to 2a3dccf Compare March 13, 2025 19:35
@Serock3 Serock3 marked this pull request as ready for review March 13, 2025 19:36
@Serock3 Serock3 merged commit 2143479 into main Mar 13, 2025
60 checks passed
@Serock3 Serock3 deleted the remove-relay-query-builder-any-protocol branch March 13, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daemon Issues related to mullvad-daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants