Stop overwriting daita params with #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
mojganii
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Reviewable status:
pinkisemils
force-pushed
the
daita-is-not-actually-used-when-multihop-is-used-ios-1111
branch
from
d75a3dc to
6b9c74c
Compare
pinkisemils
deleted the
daita-is-not-actually-used-when-multihop-is-used-ios-1111
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our multihop peer exchanger was receiving 2 private keys, first with daita paremeters, and then 2nd time around with
nildaita parameters. This then resulted in the peer exchanging pipeline overwriting the stored DAITA parameters. This changeset fixes that and adds a test to see that the daita parameters persist.This change is