Skip to content
This repository was archived by the owner on Jan 21, 2024. It is now read-only.

Override noContent response method name #15

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jpfaria
Copy link

@jpfaria jpfaria commented May 13, 2014

Hi,

There is a conflict for the 204 status. The noContent generated method conflicts with the JAX-RS specification.

"noContent() in org.raml.jaxrs.example.resource.Products.PostProductsByProductIdPresentationsResponse cannot override noContent() in javax.ws.rs.core.Response"

@ddossot
Copy link
Contributor

ddossot commented Aug 21, 2014

This pull request looks pretty important but unfortunately it contains way more changes than just fixing the noContent method name (including the archiva.ideais repositories configuration). Also there's no new test created to validate it.

The best is that you create a branch in your clone (say x-no-content-fix) from the latest version of master and then issue a pull-request from this branch.

@ddossot
Copy link
Contributor

ddossot commented Aug 23, 2014

Wait, this fix is in master already: https://github.com/mulesoft/raml-jaxrs-codegen/blob/master/core/src/main/java/org/raml/jaxrs/codegen/core/Names.java#L80

Why isn't this pull request closed then?

@ddossot
Copy link
Contributor

ddossot commented Aug 23, 2014

@KonstantinSviridov I think this can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants