This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Fixed some ClassCastException. #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were caused by the casting to (Class) of a type that was that was: java.lang.reflect.ParameterizedType or java.lang.reflect.TypeVariable
…we have to cast it to Class. Fixed minor typo in AnnotationInstanceEmitter.java
|
I'll look at this today. Thanks. |
|
I've merged you pull request and added UTs. To the question of TypeVariable and what to do with it, right now, I throw an exception, since there are no good raml responses I could write (or no way I could pull an annotation on a potientially unbounded variable). Opinions ? |
|
Oh, and thanks for fixing the variable names. And the typos :-) |
|
Closing this since it has been merged already in another branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were caused by the casting to (Class) of a type that was a java.lang.reflect.ParameterizedType or java.lang.reflect.TypeVariable.
This seems to happen when the type to generate is for a class that contains generics