fix(client): issue#228 syntax changes cause of create-react-app v5 issue #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. can you please check why the sonar quality check is failing? |
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
hfdem
pushed a commit
to hfdem/chat-e2ee
that referenced
this pull request
Jan 9, 2024
…sue (muke1908#229) * fix(client): issue#228 syntax changes cause of create-react-app v5 issue * fix(client): issue#228 syntax changes cause of create-react-app v5 issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is stated here facebook/create-react-app#11800 the syntax
import { style } from style.module.cssis not working correctly, hence the errors of issue#228. I changed the syntax along with the newest version of react-scripts in package.json in order to work for me, otherwise i had webpack compiler errors