-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fields] Fix Android editing #7444
Conversation
dadf2d8
to
d2300b9
Compare
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was hard to reproduce. I don't have the bug with Gboard.
What about adding a test to catch this error?
Do you have an idea of how to test those Android-only behaviors ? |
I was thinking about firing an |
I added two tests 👍 |
e34bfd8
to
e70bbd8
Compare
e70bbd8
to
6397e99
Compare
@flaviendelangle Thanks for looking into it 👌. I noticed two other things: Screen.Recording.2023-02-05.at.22.05.45.movScreen.Recording.2023-02-05.at.22.09.16.movIt can be reproduced on https://live.browserstack.com/dashboard#os=android&os_version=12.0&device=Samsung+Galaxy+S22&device_browser=chrome&zoom_to_fit=true&full_screen=true&url=https%3A%2F%2Fy2jlm1.csb.app%2F&speed=1&host_ports=google.com%2C80%2C0. |
1st bug reproduced, that's not specific to Android, #7834 |
2nd bug reproduced. |
Part of #7440
In Android, we have 2
onChange
, for the 1st one we need to just store the result as is in the input.Since the RTL PR, we were storing the clean value (without the RTL characters), which was causing shift in the edited layout on the 2nd
onChange
.