Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Rename column header button component names, classes and slots #16769

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[DataGrid] Rename column header button component names, classes and slots #16769

wants to merge 3 commits into from
+233 −358

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Feb 28, 2025 •
edited
Loading

Not sure if we want to do this so close to the beta, or at all, but I noticed some inconsistencies in naming whilst fixing #13404 and it felt like a good opportunity to clean them up.

Changelog

Breaking changes

  • Renamed the columnHeaderSortIcon slot to columnHeaderSortButton
  • Renamed the columnHeaderFilterIconButton slot to columnHeaderFilterButton
  • Renamed the GridColumnHeaderSortIcon component to GridColumnHeaderSortButton
  • Renamed the GridColumnHeaderFilterIconButton component to GridColumnHeaderFilterButton
  • Renamed the GridColumnHeaderSortIconProps interface to GridColumnHeaderSortButtonProps
  • Renamed the ColumnHeaderFilterIconButtonProps interface to GridColumnHeaderFilterButtonProps

@KenanYusuf KenanYusuf added breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x labels Feb 28, 2025
@mui-bot
Copy link

mui-bot commented Feb 28, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16769--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against df8a13e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenanYusuf @mui-bot