[DataGrid] Use readonly array for GridSortModel #16627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannager
added
the
component: data grid
romgrk
reviewed
Feb 17, 2025
pcorpet
force-pushed
the
readonly-initial
branch
from
143230c to
b87b7dc
Compare
romgrk
approved these changes
Feb 18, 2025
|
Deploy preview: https://deploy-preview-16627--material-ui-x.netlify.app/ |
|
Some typings need adjusting. |
Indeed, and that might somehow break compatibility: if you have any client code that use const [sortingModel, setSortingModel] = useState<GridSortItem[]>([])
...would need to be updated, either by setting a Is that ok? |
pcorpet
force-pushed
the
readonly-initial
branch
from
1762c08 to
65e1a28
Compare
arminmeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix the type of the GridSortModel to allow readonly arrays.