Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add demo for Scatter Chart with linked points #16505

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

bernardobelchior
Copy link
Member

Add demo for Scatter Chart with linked points. Fixes #15147.

Original PR

image

@bernardobelchior bernardobelchior added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Feb 7, 2025
@mui-bot
Copy link

mui-bot commented Feb 7, 2025

Deploy preview: https://deploy-preview-16505--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against ee4ca2e

Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #16505 will not alter performance

Comparing bernardobelchior:docs-line-scatter-chart (ee4ca2e) with master (3ba4176)

Summary

✅ 6 untouched benchmarks

@bernardobelchior bernardobelchior marked this pull request as ready for review February 7, 2025 16:05
@@ -116,3 +116,14 @@ See [Axis—Grid](/x/react-charts/axis/#grid) documentation for more information
### Shape 🚧

### Size 🚧

## Plot Customization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we out this above the 🚧 above? We might want to remove them instead 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove them. Maybe adding issues with waiting for upvote for the associated feature

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that, but what are those sections meant to contain?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the size and shape of the items in the scatter chart

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working on this and as far as I can tell there's no way to customize the shape of a scatter point because it always renders a circle. There is a labelMarkType, but it only applies to tooltip and legends, so would it make sense to create a slot for ScatterItem or ScatterPoint to allow it to be customized? We could potentially allow a markerType instead for a higher-level API.

@bernardobelchior bernardobelchior merged commit 3e77317 into mui:master Feb 10, 2025
22 of 23 checks passed
@bernardobelchior bernardobelchior deleted the docs-line-scatter-chart branch February 10, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] Scatter Chart allow to link points
4 participants