[DataGrid] Add resetPageOnSortFilter prop that resets the page after sorting/filtering
#16450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
component: data grid
arminmeh
commented
Feb 4, 2025
arminmeh
commented
Feb 6, 2025
packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
Show resolved
Hide resolved
arminmeh
changed the title
resetPageAfterSortingOrFiltering prop that resets the page after sorting/filteringresetPageOnSortFilter prop that resets the page after sorting/filtering
arminmeh
force-pushed
the
reset-page-opt-in
branch
from
20ffdf4 to
a3ad812
Compare
arminmeh
commented
Feb 12, 2025
MBilalShafi
reviewed
Feb 12, 2025
| @@ -8,6 +8,10 @@ The example below demonstrates how to achieve server-side filtering. | |||
|
|
|||
| {{"demo": "ServerFilterGrid.js", "bg": "inline"}} | |||
|
|
|||
| :::info | |||
| Combine server-side filtering with [Server-side sorting](/x/react-data-grid/sorting/#server-side-sorting) and [Server-side pagination](/x/react-data-grid/pagination/#server-side-pagination) to avoid fetching more data than needed, since you already process the data outside of the Data Grid. | |||
There was a problem hiding this comment.
The following text would be more relatable for me. Also, I'd like to keep it as warning, as to me this call-out is not for an "improved" but a "proper" implementation.
Suggested change
| Combine server-side filtering with [Server-side sorting](/x/react-data-grid/sorting/#server-side-sorting) and [Server-side pagination](/x/react-data-grid/pagination/#server-side-pagination) to avoid fetching more data than needed, since you already process the data outside of the Data Grid. | |
| To have a proper server-side binding, you should combine server-side filtering with [Server-side sorting](/x/react-data-grid/sorting/#server-side-sorting) and [Server-side pagination](/x/react-data-grid/pagination/#server-side-pagination). |
There was a problem hiding this comment.
Having the text updated would warrant IMO an update to a warning callout. As I am still more in favor of keeping it as info I would also like to keep the text as is.
packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
Outdated
Show resolved
Hide resolved
arminmeh
force-pushed
the
reset-page-opt-in
branch
from
6954442 to
e1bbb5d
Compare
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com> Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com> Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
MBilalShafi
approved these changes
Feb 13, 2025
packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
Outdated
Show resolved
Hide resolved
| expect(apiRef.current!.state.pagination.paginationModel.page).to.equal(1); | ||
|
|
||
| act(() => { | ||
| apiRef.current?.sortColumn('id', 'desc'); |
There was a problem hiding this comment.
Use ! throughout instead of ??
Suggested change
| apiRef.current?.sortColumn('id', 'desc'); | |
| apiRef.current!.sortColumn('id', 'desc'); |
There was a problem hiding this comment.
I plan to do this for the whole repo in another PR
|
Cherry-pick PRs will be created targeting branches: v7.x |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
…r sorting/filtering (#16450) Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com>
1 task
arminmeh
added a commit
that referenced
this pull request
Feb 14, 2025
…r sorting/filtering (#16450) Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com>
This was referenced Feb 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realted to #15378
It is a first PR that will be cherry-picked to v7
#16447 will remove the prop for v8 and include migration notes
Preview
https://deploy-preview-16450--material-ui-x.netlify.app/x/react-data-grid/sorting/#reset-page-on-sorting
https://deploy-preview-16450--material-ui-x.netlify.app/x/react-data-grid/filtering/#reset-page-on-filtering