Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Make base data source available in the Community plan #16359

Merged
merged 18 commits into from
Feb 10, 2025
Merged

[DataGrid] Make base data source available in the Community plan #16359

merged 18 commits into from
Feb 10, 2025

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Jan 27, 2025 •
edited
Loading

Resolves #15373

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! feature: Server integration Better integration with backends, e.g. data source labels Jan 27, 2025
@mui-bot
Copy link

mui-bot commented Jan 27, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16359--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against c9f31db

@MBilalShafi MBilalShafi marked this pull request as ready for review January 28, 2025 11:04
@MBilalShafi MBilalShafi requested a review from a team January 28, 2025 11:04
@MBilalShafi MBilalShafi mentioned this pull request Jan 28, 2025
Draft
9 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 30, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 30, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 30, 2025
@MBilalShafi MBilalShafi changed the title [DataGrid] Make basic data source available for MIT users [DataGrid] Make base data source available in the Community plan Jan 30, 2025
@MBilalShafi
Copy link
Member Author

Side note: We could use similar approach used to split data source logic to split other hooks which have Pro or Premium logic spilled in Community package, e.g useGridKeyboardNavigation, useGridFocus, etc.

@arminmeh
Copy link
Contributor

Side note: We could use similar approach used to split data source logic to split other hooks which have Pro or Premium logic spilled in Community package, e.g useGridKeyboardNavigation, useGridFocus, etc.

There is also a configuration provider which allows partial overrides per package

arminmeh
arminmeh approved these changes Feb 10, 2025
View reviewed changes
@MBilalShafi MBilalShafi enabled auto-merge (squash) February 10, 2025 12:37
@MBilalShafi MBilalShafi merged commit 04c75a5 into mui:master Feb 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk left review comments

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Server integration Better integration with backends, e.g. data source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Make basic data source features available in community plan
4 participants
@MBilalShafi @mui-bot @arminmeh @romgrk