Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix EditingWithDatePickers demo #15967

Merged
merged 10 commits into from
Dec 31, 2024
+20 −5
Merged

[docs] Fix EditingWithDatePickers demo #15967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f6e6eee
handle Focus and use new accessible DOM structure in demo
k-rajat19 Dec 21, 2024
f9eb07d
Merge branch 'master' into editing-date-pickers
k-rajat19 Dec 21, 2024
ae2cf69
prettier changes
k-rajat19 Dec 21, 2024
e0709c0
Merge branch 'editing-date-pickers' of github.com:k-rajat19/mui-x int…
k-rajat19 Dec 21, 2024
efc71c0
fix
k-rajat19 Dec 21, 2024
d329292
Merge branch 'master' of github.com:k-rajat19/mui-x into editing-date…
k-rajat19 Dec 31, 2024
15de05f
handle focus
k-rajat19 Dec 31, 2024
430a68d
transpile demo
k-rajat19 Dec 31, 2024
77e599f
fix
k-rajat19 Dec 31, 2024
6b5fd3d
pass default value in ref
k-rajat19 Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions docs/data/data-grid/custom-columns/EditingWithDatePickers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { DateTimePicker } from '@mui/x-date-pickers/DateTimePicker';
import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns';
import { enUS as locale } from 'date-fns/locale';
import format from 'date-fns/format';

import { unstable_useEnhancedEffect as useEnhancedEffect } from '@mui/utils';
/**
* `date` column
*/
Expand All @@ -41,22 +41,29 @@ const dateColumnType = {
},
};

function GridEditDateCell({ id, field, value, colDef }) {
function GridEditDateCell({ id, field, value, colDef, hasFocus }) {
const apiRef = useGridApiContext();

const inputRef = React.useRef(null);
const Component = colDef.type === 'dateTime' ? DateTimePicker : DatePicker;

const handleChange = (newValue) => {
apiRef.current.setEditCellValue({ id, field, value: newValue });
};

useEnhancedEffect(() => {
if (hasFocus) {
inputRef.current.focus();
}
}, [hasFocus]);

return (
<Component
value={value}
autoFocus
onChange={handleChange}
slotProps={{
textField: {
inputRef,
variant: 'standard',
fullWidth: true,
sx: {
Expand Down
12 changes: 10 additions & 2 deletions docs/data/data-grid/custom-columns/EditingWithDatePickers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { DateTimePicker } from '@mui/x-date-pickers/DateTimePicker';
import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns';
import { enUS as locale } from 'date-fns/locale';
import format from 'date-fns/format';

import { unstable_useEnhancedEffect as useEnhancedEffect } from '@mui/utils';
/**
* `date` column
*/
Expand Down Expand Up @@ -51,22 +51,30 @@ function GridEditDateCell({
field,
value,
colDef,
hasFocus,
}: GridRenderEditCellParams<any, Date | null, string>) {
const apiRef = useGridApiContext();

const inputRef = React.useRef<HTMLInputElement>(null);
const Component = colDef.type === 'dateTime' ? DateTimePicker : DatePicker;

const handleChange = (newValue: unknown) => {
apiRef.current.setEditCellValue({ id, field, value: newValue });
};

useEnhancedEffect(() => {
if (hasFocus) {
inputRef.current!.focus();
}
}, [hasFocus]);

return (
<Component
value={value}
autoFocus
onChange={handleChange}
slotProps={{
textField: {
inputRef,
variant: 'standard',
fullWidth: true,
sx: {
Expand Down
Loading