Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data grid] Fix number of rows to display for page size options with negative value #14890

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

kalyan90
Copy link
Contributor

@kalyan90 kalyan90 commented Oct 9, 2024

This PR is created to address #14276

Unable to attach labels to the PR, can someone please help with attaching the labels

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Oct 9, 2024
@kalyan90
Copy link
Contributor Author

@romgrk can you please look at these changes when you have time?

@kalyan90
Copy link
Contributor Author

@michelengelen can you please help with review for this PR?

Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small adjustment, could you add a note about this behavior somewhere in the docs?

Also maybe just settle on using -1 strictly rather than any negative value, imho it's more clear.

@mui-bot
Copy link

mui-bot commented Oct 17, 2024

@kalyan90
Copy link
Contributor Author

@romgrk addressed the comments, please review you again when you get sometime.
also please merge if everything is okay, I don't have write access to the repo.

@romgrk romgrk enabled auto-merge (squash) October 18, 2024 18:44
@romgrk romgrk merged commit 2880c9a into mui:master Oct 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants