[List] Make List & ListItem semantic #7444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
accessibility
oliviertassinari
changed the title
In List.js change default prop 'component' to 'ul' and make corresponding changes to List.spec.js and in ListItem.js change default prop 'component' to 'li'. Now by default List should be a 'ul' and ListItem should be an 'li'. Also changed affected integration test in MenuList.spec.js.
|
@akshaynaik404 Sorry for the delay, I have fixed the CI. |
|
Alright, no visual regressions, let's merge :). |
|
Thanks for this second contribution 🏇 ! |
|
3 years later, it's close 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In List.js change default prop 'component' to 'ul' and make corresponding
changes to List.spec.js and in ListItem.js change default prop 'component'
to 'li'.
Now by default List should be a 'ul' and ListItem should be an 'li'.
Also changed affected integration test in MenuList.spec.js.
Please note that I am new to this repo. If I have made any silly mistakes or I should do something differently, DO TELL.
Closes #1168.