Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Also take fixed element into account #7239

Merged
merged 1 commit into from
Jun 24, 2017
Merged

[Dialog] Also take fixed element into account #7239

merged 1 commit into from
Jun 24, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 24, 2017

Closes #7096

juin-24-2017 23-57-58

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! v1.x.x labels Jun 24, 2017
@dsaco
Copy link

dsaco commented Jul 28, 2017

just now i upgrade to1.0.0-beta.2 (windows system , chrome browser)
it's remove popover and use menu
the problem is : if the body is long and has vertical scrollbar it's ok,
when the boby is short, add padding-right to body
every open cause the page layout change (a little strange)
follow is picture
short body normal
short body open menu
is this a right thing ? if you can understand this words , please reply me

@oliviertassinari
Copy link
Member Author

I'm not sure, it would be great to have a reproduction example.

@dsaco
Copy link

dsaco commented Jul 28, 2017

upload code take some times...
this is the demo sandbox

@oliviertassinari
Copy link
Member Author

@dsaco Sounds like an issue yes. It would be perfect to have a small reproduction example on codesandbox or webpackbin to further investigate.

@dsaco
Copy link

dsaco commented Jul 29, 2017

this is codesandbox url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dialog] AutoScrollBodyContent
2 participants