Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Remove transition onX props #22212

Merged
merged 1 commit into from
Aug 15, 2020
Merged

[Menu] Remove transition onX props #22212

merged 1 commit into from
Aug 15, 2020

Conversation

mbrookes
Copy link
Member

Menu

The onE* transition props were removed. Use TransitionProps instead.

<Menu
-  onEnter={onEnter}
-  onEntered={onEntered},
-  onEntering={onEntered},
-  onExit={onEntered},
-  onExited={onEntered},
-  onExiting={onEntered}
+  TransitionProps={{
+    onEnter,
+    onEntered,
+    onEntering,
+    onExit,
+    onExited,
+    onExiting,
+  }}
>

#17047 (comment)

@mbrookes mbrookes added breaking change component: menu This is the name of the generic UI component, not the React module! labels Aug 15, 2020
@mbrookes mbrookes added this to the v5 milestone Aug 15, 2020
@mbrookes mbrookes force-pushed the menu-remove-popover-onX branch 3 times, most recently from 428867c to 062f988 Compare August 15, 2020 12:03
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 15, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 785a68f

@mbrookes mbrookes force-pushed the menu-remove-popover-onX branch from 062f988 to 785a68f Compare August 15, 2020 12:18
@mbrookes mbrookes mentioned this pull request Aug 15, 2020
Merged
@oliviertassinari oliviertassinari merged commit 83ed1cf into mui:next Aug 15, 2020
@mbrookes mbrookes deleted the menu-remove-popover-onX branch August 15, 2020 21:16
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrookes @mui-pr-bot @oliviertassinari