Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Hide duplicate table borders #20809

Merged
merged 14 commits into from
Jun 18, 2020
Merged

[docs] Hide duplicate table borders #20809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
48e2130
[Table] add hide last border property
marcosvega91 Apr 28, 2020
a1fe473
[TableContext] Add missing stickyHeader property
marcosvega91 Apr 28, 2020
3667fe8
[Table] move props up
marcosvega91 Apr 28, 2020
16c0af4
[Table] change doc
marcosvega91 Apr 28, 2020
d9b7920
[TableRow] Add props to hide border
marcosvega91 Apr 30, 2020
f05fd3e
Update demos
marcosvega91 Apr 30, 2020
6670162
Remove hide border from table row and add to table cell
marcosvega91 May 5, 2020
c6d77b6
Fix test
marcosvega91 May 5, 2020
6abdee0
Run prettier
marcosvega91 May 5, 2020
008c7dd
Run yar docs:api
marcosvega91 May 5, 2020
9c3413d
Fix linter
marcosvega91 May 5, 2020
63f363d
fix linter
marcosvega91 May 5, 2020
97bfdbe
polish
oliviertassinari Jun 13, 2020
6d03566
simpler approach
oliviertassinari Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/src/pages/components/tables/CustomizedTables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ const StyledTableRow = withStyles((theme) => ({
'&:nth-of-type(odd)': {
backgroundColor: theme.palette.action.hover,
},
// hide last border
'&:last-child td, &:last-child th': {
border: 0,
},
},
}))(TableRow);

Expand Down
4 changes: 4 additions & 0 deletions docs/src/pages/components/tables/CustomizedTables.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ const StyledTableRow = withStyles((theme: Theme) =>
'&:nth-of-type(odd)': {
backgroundColor: theme.palette.action.hover,
},
// hide last border
'&:last-child td, &:last-child th': {
border: 0,
},
},
}),
)(TableRow);
Expand Down
7 changes: 6 additions & 1 deletion docs/src/pages/components/tables/DenseTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ const useStyles = makeStyles({
table: {
minWidth: 650,
},
hideLastBorder: {
'&:last-child td, &:last-child th': {
border: 0,
},
},
});

function createData(name, calories, fat, carbs, protein) {
Expand Down Expand Up @@ -43,7 +48,7 @@ export default function DenseTable() {
</TableHead>
<TableBody>
{rows.map((row) => (
<TableRow key={row.name}>
<TableRow key={row.name} className={classes.hideLastBorder}>
<TableCell component="th" scope="row">
{row.name}
</TableCell>
Expand Down
7 changes: 6 additions & 1 deletion docs/src/pages/components/tables/DenseTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ const useStyles = makeStyles({
table: {
minWidth: 650,
},
hideLastBorder: {
'&:last-child td, &:last-child th': {
border: 0,
},
},
});

function createData(name: string, calories: number, fat: number, carbs: number, protein: number) {
Expand Down Expand Up @@ -43,7 +48,7 @@ export default function DenseTable() {
</TableHead>
<TableBody>
{rows.map((row) => (
<TableRow key={row.name}>
<TableRow key={row.name} className={classes.hideLastBorder}>
<TableCell component="th" scope="row">
{row.name}
</TableCell>
Expand Down
7 changes: 6 additions & 1 deletion docs/src/pages/components/tables/SimpleTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ const useStyles = makeStyles({
table: {
minWidth: 650,
},
hideLastBorder: {
'&:last-child td, &:last-child th': {
border: 0,
},
},
});

function createData(name, calories, fat, carbs, protein) {
Expand Down Expand Up @@ -43,7 +48,7 @@ export default function SimpleTable() {
</TableHead>
<TableBody>
{rows.map((row) => (
<TableRow key={row.name}>
<TableRow key={row.name} className={classes.hideLastBorder}>
<TableCell component="th" scope="row">
{row.name}
</TableCell>
Expand Down
7 changes: 6 additions & 1 deletion docs/src/pages/components/tables/SimpleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ const useStyles = makeStyles({
table: {
minWidth: 650,
},
hideLastBorder: {
'&:last-child td, &:last-child th': {
border: 0,
},
},
});

function createData(name: string, calories: number, fat: number, carbs: number, protein: number) {
Expand Down Expand Up @@ -43,7 +48,7 @@ export default function SimpleTable() {
</TableHead>
<TableBody>
{rows.map((row) => (
<TableRow key={row.name}>
<TableRow key={row.name} className={classes.hideLastBorder}>
<TableCell component="th" scope="row">
{row.name}
</TableCell>
Expand Down
3 changes: 3 additions & 0 deletions docs/src/pages/components/tables/SpanningTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ const useStyles = makeStyles({
table: {
minWidth: 700,
},
hideBorder: {
border: 0,
},
});

function ccyFormat(num) {
Expand Down
3 changes: 3 additions & 0 deletions docs/src/pages/components/tables/SpanningTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ const useStyles = makeStyles({
table: {
minWidth: 700,
},
hideBorder: {
border: 0,
},
});

function ccyFormat(num: number) {
Expand Down