-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Add new feature onHighlightChange #20691
[Autocomplete] Add new feature onHighlightChange #20691
Conversation
@material-ui/lab: parsed: +0.17% , gzip: +0.13% Details of bundle changes.Comparing: 5195c60...2ad133c Details of page changes
|
I moved event params at the end because is optional but I really don't like |
No need for a demo, a test case will be enough |
I added three test cases, the only question is about the position of the parameters that I don't like |
@marcosvega91 Ok, perfect. I have submitted a couple of follow-up changes, let me know what y ou think :) |
good 👯 |
@marcosvega91 Well done ✨ |
This closes #20588
I need only to add a demo i think.
@oliviertassinari I run
yarn typescript
but the Autocomplete.js is not changed.The new property is taken from useAutocomplete.d.ts but nothing happens in Autocomplete.js, I added it manually.