[test] Fix broken tests in react@next

.circleci/config.yml

@@ -34,7 +34,7 @@ commands:
           command: |
             node scripts/use-react-dist-tag
             # log a patch for maintainers who want to check out this change
-            git diff HEAD
+            git --no-pager diff HEAD
       - restore_cache:
           keys:
             - v2-yarn-sha-{{ checksum "yarn.lock" }}
@@ -152,7 +152,7 @@ jobs:
           command: |
             node scripts/use-typescript-dist-tag
             # log a patch for maintainers who want to check out this change
-            git diff HEAD
+            git --no-pager diff HEAD
       - install_js
       - run:
           name: Tests TypeScript definitions
@@ -210,6 +210,8 @@ workflows:
       - test_unit:
           requires:
             - checkout
+          # REVERT_ME_OR_JUST_KIDDING_IT_WILL_BE_FINE
+          react-dist-tag: next
       - test_static:
           requires:
             - checkout
@@ -219,6 +221,8 @@ workflows:
       - test_browser:
           requires:
             - checkout
+          # REVERT_ME_OR_JUST_KIDDING_IT_WILL_BE_FINE
+          react-dist-tag: next
       - test_regressions:
           requires:
             - test_unit

packages/material-ui-styles/src/StylesProvider/StylesProvider.test.js

@@ -159,11 +159,13 @@ describe('StylesProvider', () => {
           <Test />
         </StylesProvider>,
       );
-      assert.strictEqual(consoleErrorMock.callCount(), 1);
+      assert.strictEqual(consoleErrorMock.callCount(), 2);
       assert.include(
         consoleErrorMock.messages()[0],
         'you cannot use the jss and injectFirst props at the same time',
       );
+      // one error per render (twice rendered in StrictMode)
+      assert.strictEqual(consoleErrorMock.messages()[0], consoleErrorMock.messages()[1]);
     });
   });
 });

packages/material-ui-styles/src/ThemeProvider/ThemeProvider.test.js

@@ -67,7 +67,9 @@ describe('ThemeProvider', () => {
     const text = () => ref.current.textContent;
     function Test() {
       const theme = useTheme();
-      themes.push(theme);
+      React.useEffect(() => {
+        themes.push(theme);
+      });
 
       return (
         <span ref={ref}>

packages/material-ui/src/FormControl/FormControl.test.js

@@ -3,7 +3,7 @@ import { expect } from 'chai';
 import { spy } from 'sinon';
 import { createMount, getClasses } from '@material-ui/core/test-utils';
 import describeConformance from '../test-utils/describeConformance';
-import { createClientRender } from 'test/utils/createClientRender';
+import { act, createClientRender } from 'test/utils/createClientRender';
 import Input from '../Input';
 import Select from '../Select';
 import FormControl from './FormControl';
@@ -16,7 +16,9 @@ describe('<FormControl />', () => {
 
   function TestComponent(props) {
     const context = useFormControl();
-    props.contextCallback(context);
+    React.useEffect(() => {
+      props.contextCallback(context);
+    });
     return null;
   }
 
@@ -101,7 +103,9 @@ describe('<FormControl />', () => {
       );
       expect(readContext.args[0][0]).to.have.property('focused', false);
 
-      container.querySelector('input').focus();
+      act(() => {
+        container.querySelector('input').focus();
+      });
       expect(readContext.args[1][0]).to.have.property('focused', true);
 
       setProps({ disabled: true });

packages/material-ui/src/GridList/GridList.test.js

@@ -189,11 +189,13 @@ describe('<GridList />', () => {
         </GridList>,
       );
 
-      assert.strictEqual(consoleErrorMock.callCount(), 1);
+      assert.strictEqual(consoleErrorMock.callCount(), 2);
       assert.include(
         consoleErrorMock.messages()[0],
         "Material-UI: the GridList component doesn't accept a Fragment as a child.",
       );
+      // one error per render (twice rendered in StrictMode)
+      assert.strictEqual(consoleErrorMock.messages()[0], consoleErrorMock.messages()[1]);
     });
   });
 });

packages/material-ui/src/Hidden/HiddenCss.test.js

@@ -160,11 +160,13 @@ describe('<HiddenCss />', () => {
         </HiddenCss>,
       );
 
-      assert.strictEqual(consoleErrorMock.callCount(), 1);
+      assert.strictEqual(consoleErrorMock.callCount(), 2);
       assert.include(
         consoleErrorMock.messages()[0],
         'Material-UI: unsupported props received by `<Hidden implementation="css" />`: xxlUp.',
       );
+      // one error per render (twice rendered in StrictMode)
+      assert.strictEqual(consoleErrorMock.messages()[0], consoleErrorMock.messages()[1]);
     });
   });
 });

packages/material-ui/src/InputAdornment/InputAdornment.test.js

@@ -150,11 +150,13 @@ describe('<InputAdornment />', () => {
             />
           </FormControl>,
         );
-        expect(consoleErrorMock.callCount()).to.equal(1);
+        expect(consoleErrorMock.callCount()).to.equal(2);
         expect(consoleErrorMock.messages()[0]).to.equal(
           'Material-UI: The `InputAdornment` variant infers the variant ' +
             'prop you do not have to provide one.',
         );
+        // one error per render (twice rendered in StrictMode)
+        expect(consoleErrorMock.messages()[0]).to.equal(consoleErrorMock.messages()[1]);
       });
     });
   });

packages/material-ui/src/Paper/Paper.js

@@ -1,6 +1,7 @@
 import * as React from 'react';
 import PropTypes from 'prop-types';
 import clsx from 'clsx';
+import { chainPropTypes } from '@material-ui/utils';
 import withStyles from '../styles/withStyles';
 
 export const styles = (theme) => {
@@ -41,12 +42,6 @@ const Paper = React.forwardRef(function Paper(props, ref) {
     ...other
   } = props;
 
-  if (process.env.NODE_ENV !== 'production') {
-    if (classes[`elevation${elevation}`] === undefined) {
-      console.error(`Material-UI: this elevation \`${elevation}\` is not implemented.`);
-    }
-  }
-
   return (
     <Component
       className={clsx(
@@ -91,7 +86,17 @@ Paper.propTypes = {
    * Shadow depth, corresponds to `dp` in the spec.
    * It accepts values between 0 and 24 inclusive.
    */
-  elevation: PropTypes.number,
+  elevation: chainPropTypes(PropTypes.number, (props) => {
+    const { classes, elevation } = props;
+    // in case `withStyles` fails to inject we don't need this warning
+    if (classes === undefined) {
+      return null;
+    }
+    if (elevation != null && classes[`elevation${elevation}`] === undefined) {
+      return new Error(`Material-UI: this elevation \`${elevation}\` is not implemented.`);
+    }
+    return null;
+  }),
   /**
    * If `true`, rounded corners are disabled.
    */

packages/material-ui/src/Paper/Paper.test.js

@@ -1,6 +1,7 @@
 import * as React from 'react';
 import { assert } from 'chai';
 import { createMount, createShallow, getClasses } from '@material-ui/core/test-utils';
+import * as PropTypes from 'prop-types';
 import describeConformance from '../test-utils/describeConformance';
 import Paper from './Paper';
 import { createMuiTheme, ThemeProvider } from '../styles';
@@ -11,14 +12,6 @@ describe('<Paper />', () => {
   let shallow;
   let classes;
 
-  beforeEach(() => {
-    consoleErrorMock.spy();
-  });
-
-  afterEach(() => {
-    consoleErrorMock.reset();
-  });
-
   before(() => {
     mount = createMount({ strict: true });
     shallow = createShallow({ dive: true });
@@ -77,16 +70,6 @@ describe('<Paper />', () => {
     );
   });
 
-  it('warns if the given `elevation` is not implemented in the theme', () => {
-    mount(<Paper elevation={25} />);
-
-    assert.strictEqual(consoleErrorMock.callCount(), 1);
-    assert.include(
-      consoleErrorMock.messages()[0],
-      'Material-UI: this elevation `25` is not implemented.',
-    );
-  });
-
   it('allows custom elevations via theme.shadows', () => {
     const theme = createMuiTheme();
     theme.shadows.push('20px 20px');
@@ -98,4 +81,30 @@ describe('<Paper />', () => {
 
     assert.strictEqual(wrapper.find('div[data-testid="paper"]').hasClass('custom-elevation'), true);
   });
+
+  describe('warnings', () => {
+    beforeEach(() => {
+      consoleErrorMock.spy();
+      PropTypes.resetWarningCache();
+    });
+
+    afterEach(() => {
+      consoleErrorMock.reset();
+    });
+
+    it('warns if the given `elevation` is not implemented in the theme', () => {
+      PropTypes.checkPropTypes(
+        Paper.Naked.propTypes,
+        { classes: { elevation24: 'elevation-24', elevation26: 'elevation-26' }, elevation: 25 },
+        'prop',
+        'MockedPaper',
+      );
+
+      assert.strictEqual(consoleErrorMock.callCount(), 1);
+      assert.include(
+        consoleErrorMock.messages()[0],
+        'Material-UI: this elevation `25` is not implemented.',
+      );
+    });
+  });
 });

packages/material-ui/src/Popover/Popover.test.js

@@ -2,6 +2,7 @@ import * as React from 'react';
 import { assert, expect } from 'chai';
 import { spy, stub, useFakeTimers } from 'sinon';
 import { createMount, findOutermostIntrinsic, getClasses } from '@material-ui/core/test-utils';
+import * as PropTypes from 'prop-types';
 import describeConformance from '../test-utils/describeConformance';
 import consoleErrorMock from 'test/utils/consoleErrorMock';
 import Grow from '../Grow';
@@ -460,25 +461,37 @@ describe('<Popover />', () => {
   describe('warnings', () => {
     beforeEach(() => {
       consoleErrorMock.spy();
+      PropTypes.resetWarningCache();
     });
 
     afterEach(() => {
       consoleErrorMock.reset();
     });
 
     it('should warn if anchorEl is not valid', () => {
-      const otherWrapper = mount(<Popover open />);
-      assert.strictEqual(otherWrapper.find(Modal).props().container, undefined);
+      PropTypes.checkPropTypes(
+        Popover.Naked.propTypes,
+        { classes: {}, open: true },
+        'prop',
+        'MockedPopover',
+      );
+
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(consoleErrorMock.messages()[0], 'It should be an Element instance');
     });
 
     it('warns if a component for the Paper is used that cant hold a ref', () => {
-      mount(<Popover {...defaultProps} PaperProps={{ component: () => <div />, elevation: 4 }} />);
+      PropTypes.checkPropTypes(
+        Popover.Naked.propTypes,
+        { ...defaultProps, classes: {}, PaperProps: { component: () => <div />, elevation: 4 } },
+        'prop',
+        'MockedPopover',
+      );
+
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
         consoleErrorMock.messages()[0],
-        'Warning: Failed prop type: Invalid prop `PaperProps.component` supplied to `ForwardRef(Popover)`. Expected an element type that can hold a ref.',
+        'Warning: Failed prop type: Invalid prop `PaperProps.component` supplied to `MockedPopover`. Expected an element type that can hold a ref.',
       );
     });
 

scripts/use-react-dist-tag.js

@@ -45,7 +45,10 @@ async function main(distTag) {
     packageJson.resolutions[reactPackageName] = version;
   });
 
-  // CircleCI seemingly times out if it has a newline diff at the end
+  // https://github.com/enzymejs/enzyme/issues/2358
+  packageJson.devDependencies['enzyme-adapter-react-16'] = 'npm:@eps1lon/enzyme-adapter-react-next';
+
+  // add newline for clean diff
   fs.writeFileSync(packageJsonPath, `${JSON.stringify(packageJson, null, 2)}${os.EOL}`);
 }
 

scripts/use-typescript-dist-tag.js

@@ -44,7 +44,7 @@ async function main(distTag) {
   packageJson.devDependencies.typescript = version;
   packageJson.resolutions['**/dtslint/typescript'] = version;
 
-  // CircleCI seemingly times out if it has a newline diff at the end
+  // add newline for clean diff
   fs.writeFileSync(packageJsonPath, `${JSON.stringify(packageJson, null, 2)}${os.EOL}`);
 }