Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextareaAutosize] Update rows/rowMax to use number for better clarity #20469

Merged
merged 3 commits into from
Apr 8, 2020
Merged

[TextareaAutosize] Update rows/rowMax to use number for better clarity #20469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
429040e
Update rows/rowMax to use number for better clarity
esemeniuc Apr 8, 2020
2467ae0
yarn docs:typescript:formatted
oliviertassinari Apr 8, 2020
d85da1b
update tests too
oliviertassinari Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/src/pages/components/text-fields/MultilineTextFields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function MultilineTextFields() {
id="standard-multiline-flexible"
label="Multiline"
multiline
rowsMax="4"
rowsMax={4}
value={value}
onChange={handleChange}
/>
Expand All @@ -40,7 +40,7 @@ export default function MultilineTextFields() {
id="standard-multiline-static"
label="Multiline"
multiline
rows="4"
rows={4}
defaultValue="Default Value"
/>
</div>
Expand All @@ -49,7 +49,7 @@ export default function MultilineTextFields() {
id="filled-multiline-flexible"
label="Multiline"
multiline
rowsMax="4"
rowsMax={4}
value={value}
onChange={handleChange}
variant="filled"
Expand All @@ -65,7 +65,7 @@ export default function MultilineTextFields() {
id="filled-multiline-static"
label="Multiline"
multiline
rows="4"
rows={4}
defaultValue="Default Value"
variant="filled"
/>
Expand All @@ -75,7 +75,7 @@ export default function MultilineTextFields() {
id="outlined-multiline-flexible"
label="Multiline"
multiline
rowsMax="4"
rowsMax={4}
value={value}
onChange={handleChange}
variant="outlined"
Expand All @@ -91,7 +91,7 @@ export default function MultilineTextFields() {
id="outlined-multiline-static"
label="Multiline"
multiline
rows="4"
rows={4}
defaultValue="Default Value"
variant="outlined"
/>
Expand Down
12 changes: 6 additions & 6 deletions docs/src/pages/components/text-fields/MultilineTextFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function MultilineTextFields() {
id="standard-multiline-flexible"
label="Multiline"
multiline
rowsMax="4"
rowsMax={4}
value={value}
onChange={handleChange}
/>
Expand All @@ -42,7 +42,7 @@ export default function MultilineTextFields() {
id="standard-multiline-static"
label="Multiline"
multiline
rows="4"
rows={4}
defaultValue="Default Value"
/>
</div>
Expand All @@ -51,7 +51,7 @@ export default function MultilineTextFields() {
id="filled-multiline-flexible"
label="Multiline"
multiline
rowsMax="4"
rowsMax={4}
value={value}
onChange={handleChange}
variant="filled"
Expand All @@ -67,7 +67,7 @@ export default function MultilineTextFields() {
id="filled-multiline-static"
label="Multiline"
multiline
rows="4"
rows={4}
defaultValue="Default Value"
variant="filled"
/>
Expand All @@ -77,7 +77,7 @@ export default function MultilineTextFields() {
id="outlined-multiline-flexible"
label="Multiline"
multiline
rowsMax="4"
rowsMax={4}
value={value}
onChange={handleChange}
variant="outlined"
Expand All @@ -93,7 +93,7 @@ export default function MultilineTextFields() {
id="outlined-multiline-static"
label="Multiline"
multiline
rows="4"
rows={4}
defaultValue="Default Value"
variant="outlined"
/>
Expand Down
4 changes: 2 additions & 2 deletions packages/material-ui/src/InputBase/InputBase.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ describe('<InputBase />', () => {
});

it('should render an <textarea /> when passed the multiline and rows props', () => {
const { container } = render(<InputBase multiline rows="4" />);
const { container } = render(<InputBase multiline rows={4} />);
expect(container.querySelectorAll('textarea')).to.have.lengthOf(1);
});

it('should forward the value to the TextareaAutosize', () => {
const wrapper = mount(<InputBase multiline rowsMax="4" value="" />);
const wrapper = mount(<InputBase multiline rowsMax={4} value="" />);
expect(wrapper.find(TextareaAutosize).props()).to.have.property('value', '');
});
});
Expand Down
4 changes: 2 additions & 2 deletions test/regressions/tests/Textarea/Textarea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ function Textarea() {
input: classes.input2,
}}
/>
<Input className={classes.input} multiline placeholder="rows" rows="3" />
<Input className={classes.input} multiline placeholder="rows" rows={3} />
<Input
className={classes.input}
multiline
value={value}
onChange={handleChange}
rowsMax="4"
rowsMax={4}
/>
<Input className={classes.input} multiline placeholder="long placeholder long placeholder" />
<Input
Expand Down