Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve out-of-date PR story #20341

Merged
merged 2 commits into from
Mar 30, 2020
Merged

[core] Improve out-of-date PR story #20341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b2aa1e
ci: run prettier first
eps1lon Mar 30, 2020
c5c10f3
PR: needs rebase -> PR: out-of-date
eps1lon Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ jobs:
steps:
- checkout
- install_js
- run:
name: Check if yarn prettier was run
command: yarn prettier check-changed
- run:
name: Generate PropTypes
command: yarn proptypes --disable-cache
Expand All @@ -118,9 +121,6 @@ jobs:
- run:
name: '`yarn docs:api` changes committed?'
command: git diff --exit-code
- run:
name: Check if yarn prettier was run
command: yarn prettier check-changed
- run:
name: Lint
command: yarn lint:ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maintenance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: check if prs are dirty
uses: eps1lon/actions-label-merge-conflict@releases/1.x
with:
dirtyLabel: 'PR: needs rebase'
dirtyLabel: 'PR: out-of-date'
removeOnDirtyLabel: 'PR: ready to ship'
repoToken: '${{ secrets.GITHUB_TOKEN }}'
retryAfter: 130
Expand Down