Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[withMobileDialog] Improve types #15276

Merged
merged 2 commits into from
Apr 9, 2019
Merged

[withMobileDialog] Improve types #15276

merged 2 commits into from
Apr 9, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 9, 2019

Motivated by https://stackoverflow.com/q/55547408/3406963.

Brings withMobileDialog in line with the other higher-order components.

This PR also disables the no-empty-interface rule. The rationale for this rule is incorrect. interface is not equivalent to type.

@eps1lon eps1lon added new feature New feature or request typescript package: material-ui Specific to @mui/material labels Apr 9, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 650ddda...e769020

Generated by 🚫 dangerJS against e769020

@sperry94 sperry94 mentioned this pull request Apr 9, 2019
Merged
1 task
@eps1lon eps1lon merged commit 1d32f23 into mui:next Apr 9, 2019
@eps1lon eps1lon deleted the fix/core/withMobileDialog/types branch April 9, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
new feature New feature or request package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari