[docs] More Table TypeScript demos #15086
Conversation
jasondashwang
commented
Mar 28, 2019
•
jasondashwang
commented
- I have followed (at least) the PR section of the contributing guide.
|
No bundle size changes comparing 2dedcc1...602e53f |
|
I am having trouble with some of the |
oliviertassinari
added
docs
oliviertassinari
changed the title
| @@ -118,6 +118,7 @@ function CustomPaginationActionsTable() { | |||
| createData('Oreo', 437, 18.0), | |||
| ].sort((a, b) => (a.calories < b.calories ? -1 : 1)), | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
this was auto generated by the yarn docs:typescript:formatted even though the TS version does not have these spaces
There was a problem hiding this comment.
That's fine. This is a transpilation artifact. The whitespace is inserted because the types added additional whitespace in the TS version and babel tries to align the corresponding lines. Since JS naturally has less lines whitespace gets inserted
|
@joshwooding I don't understand this error. I did not change anything with |
|
@jasondashwang It’s a problem with our visual regression tests. Thanks for your hard work! |
| @@ -118,6 +118,7 @@ function CustomPaginationActionsTable() { | |||
| createData('Oreo', 437, 18.0), | |||
| ].sort((a, b) => (a.calories < b.calories ? -1 : 1)), | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
That's fine. This is a transpilation artifact. The whitespace is inserted because the types added additional whitespace in the TS version and babel tries to align the corresponding lines. Since JS naturally has less lines whitespace gets inserted
eps1lon
changed the title
|
@jasondashwang Much appreciated. Thanks. |
