Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix handle case where ref is null #10006

Merged
merged 1 commit into from
Jan 24, 2018
Merged

[Slider] Fix handle case where ref is null #10006

merged 1 commit into from
Jan 24, 2018

Conversation

jony89
Copy link
Contributor

@jony89 jony89 commented Jan 23, 2018

while unmounting this.track is null and exception is raised.
returning 0 offset when no ref.

fixes #8969

while unmounting `this.track` is null and exception is raised. 
returning 0 offset when no ref.
@mbrookes mbrookes added the v0.x label Jan 23, 2018
@mbrookes mbrookes assigned mbrookes and m2mathew and unassigned mbrookes Jan 23, 2018
@oliviertassinari oliviertassinari merged commit ac9c8d3 into mui:master Jan 24, 2018
@jony89 jony89 deleted the patch-1 branch January 24, 2018 17:54
djbuckley added a commit to manchesergit/material-ui that referenced this pull request Jan 25, 2018
* call_em_all_-_master/master:
  fix: handle case where ref is null (mui#10006)
  The Popover does not listen to events unless it is open at the moment (mui#9482)
  [docs] Add v1 recommendation to home page (mui#9727)
  [Tabs] Add support for inline style override for parent container of InkBar (mui#9598)

# Conflicts:
#	src/Popover/Popover.js
@jony89
Copy link
Contributor Author

jony89 commented Jan 30, 2018

Hey @mbrookes , when a release will be out ? tnx !

djbuckley added a commit to manchesergit/material-ui that referenced this pull request Apr 21, 2018
* commit 'fbfd478b85d02c1fc61ce525bee832f960792bfa':
  Use selectionEnd instead of selectionEnd to fix caret position issue (mui#10214)
  Static properties for reason string constants (mui#10300)
  conditionally apply overlay bkg (mui#9811)
  fix: handle case where ref is null (mui#10006)
  [EnhancedButton] Fix onClick event being fired twice on "Enter Key" press (mui#9439)
  The Popover does not listen to events unless it is open at the moment (mui#9482)
  [docs] Add v1 recommendation to home page (mui#9727)
  [Tabs] Add support for inline style override for parent container of InkBar (mui#9598)

# Conflicts:
#	src/Popover/Popover.js
#	src/Slider/Slider.js
#	src/Snackbar/Snackbar.js
@oliviertassinari oliviertassinari changed the title fix: handle case where ref is null [Slider] Fix handle case where ref is null May 13, 2018
mcliwanow pushed a commit to pronos-eu/material-ui that referenced this pull request Dec 11, 2019
while unmounting `this.track` is null and exception is raised. 
returning 0 offset when no ref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants