[TextareaAutosize] Update rows/rowMax to use number for better clarity (

#20469)
mui · Apr 8, 2020 · e9eb2df · e9eb2df
1 parent 8558ec2
commit e9eb2df
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/docs/src/pages/components/text-fields/MultilineTextFields.js b/docs/src/pages/components/text-fields/MultilineTextFields.js
@@ -26,7 +26,7 @@ export default function MultilineTextFields() {
           id="standard-multiline-flexible"
           label="Multiline"
           multiline
-          rowsMax="4"
+          rowsMax={4}
           value={value}
           onChange={handleChange}
         />
@@ -40,7 +40,7 @@ export default function MultilineTextFields() {
           id="standard-multiline-static"
           label="Multiline"
           multiline
-          rows="4"
+          rows={4}
           defaultValue="Default Value"
         />
       </div>
@@ -49,7 +49,7 @@ export default function MultilineTextFields() {
           id="filled-multiline-flexible"
           label="Multiline"
           multiline
-          rowsMax="4"
+          rowsMax={4}
           value={value}
           onChange={handleChange}
           variant="filled"
@@ -65,7 +65,7 @@ export default function MultilineTextFields() {
           id="filled-multiline-static"
           label="Multiline"
           multiline
-          rows="4"
+          rows={4}
           defaultValue="Default Value"
           variant="filled"
         />
@@ -75,7 +75,7 @@ export default function MultilineTextFields() {
           id="outlined-multiline-flexible"
           label="Multiline"
           multiline
-          rowsMax="4"
+          rowsMax={4}
           value={value}
           onChange={handleChange}
           variant="outlined"
@@ -91,7 +91,7 @@ export default function MultilineTextFields() {
           id="outlined-multiline-static"
           label="Multiline"
           multiline
-          rows="4"
+          rows={4}
           defaultValue="Default Value"
           variant="outlined"
         />

diff --git a/docs/src/pages/components/text-fields/MultilineTextFields.tsx b/docs/src/pages/components/text-fields/MultilineTextFields.tsx
@@ -28,7 +28,7 @@ export default function MultilineTextFields() {
           id="standard-multiline-flexible"
           label="Multiline"
           multiline
-          rowsMax="4"
+          rowsMax={4}
           value={value}
           onChange={handleChange}
         />
@@ -42,7 +42,7 @@ export default function MultilineTextFields() {
           id="standard-multiline-static"
           label="Multiline"
           multiline
-          rows="4"
+          rows={4}
           defaultValue="Default Value"
         />
       </div>
@@ -51,7 +51,7 @@ export default function MultilineTextFields() {
           id="filled-multiline-flexible"
           label="Multiline"
           multiline
-          rowsMax="4"
+          rowsMax={4}
           value={value}
           onChange={handleChange}
           variant="filled"
@@ -67,7 +67,7 @@ export default function MultilineTextFields() {
           id="filled-multiline-static"
           label="Multiline"
           multiline
-          rows="4"
+          rows={4}
           defaultValue="Default Value"
           variant="filled"
         />
@@ -77,7 +77,7 @@ export default function MultilineTextFields() {
           id="outlined-multiline-flexible"
           label="Multiline"
           multiline
-          rowsMax="4"
+          rowsMax={4}
           value={value}
           onChange={handleChange}
           variant="outlined"
@@ -93,7 +93,7 @@ export default function MultilineTextFields() {
           id="outlined-multiline-static"
           label="Multiline"
           multiline
-          rows="4"
+          rows={4}
           defaultValue="Default Value"
           variant="outlined"
         />

diff --git a/packages/material-ui/src/InputBase/InputBase.test.js b/packages/material-ui/src/InputBase/InputBase.test.js
@@ -47,12 +47,12 @@ describe('<InputBase />', () => {
     });
 
     it('should render an <textarea /> when passed the multiline and rows props', () => {
-      const { container } = render(<InputBase multiline rows="4" />);
+      const { container } = render(<InputBase multiline rows={4} />);
       expect(container.querySelectorAll('textarea')).to.have.lengthOf(1);
     });
 
     it('should forward the value to the TextareaAutosize', () => {
-      const wrapper = mount(<InputBase multiline rowsMax="4" value="" />);
+      const wrapper = mount(<InputBase multiline rowsMax={4} value="" />);
       expect(wrapper.find(TextareaAutosize).props()).to.have.property('value', '');
     });
   });

diff --git a/test/regressions/tests/Textarea/Textarea.js b/test/regressions/tests/Textarea/Textarea.js
@@ -48,13 +48,13 @@ function Textarea() {
           input: classes.input2,
         }}
       />
-      <Input className={classes.input} multiline placeholder="rows" rows="3" />
+      <Input className={classes.input} multiline placeholder="rows" rows={3} />
       <Input
         className={classes.input}
         multiline
         value={value}
         onChange={handleChange}
-        rowsMax="4"
+        rowsMax={4}
       />
       <Input className={classes.input} multiline placeholder="long placeholder long placeholder" />
       <Input