Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LLVM 11 #7116

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Upgrade to LLVM 11 #7116

merged 3 commits into from
Oct 20, 2020

Conversation

mati865
Copy link
Collaborator

@mati865 mati865 commented Oct 14, 2020

No description provided.

@mati865 mati865 force-pushed the llvm-11 branch 2 times, most recently from d65d485 to 9d4239c Compare October 14, 2020 20:55
@mati865
Copy link
Collaborator Author

mati865 commented Oct 14, 2020

CI bugged?

warning: filesystem: downgrading from version 2020.10-1 to version 2020.02-7
warning: pacman-mirrors: downgrading from version 20201009-1 to version 20201007-1

@mati865 mati865 closed this Oct 14, 2020
@mati865 mati865 reopened this Oct 14, 2020
@jeremyd2019
Copy link
Member

I think the sourceforge hasn't updated with the new packages yet.

@lazka
Copy link
Member

lazka commented Oct 14, 2020

(rebased on master to get some CI changes..)

@mati865
Copy link
Collaborator Author

mati865 commented Oct 14, 2020

Upstream changed a bit build process of compiler-rt. It passes for me since I have already built compiler-rt installed in the system.

I've disabled compiler-rt libs that are not built anyway (I don't remember exact issue but I think they require some features not supported by Binutils) for now.
Proper investigation will have to wait until I get time to do it.

@mati865
Copy link
Collaborator Author

mati865 commented Oct 15, 2020

Compiler-RT supported architectures: should say Compiler-RT supported architectures: i386, very funny...
Also it detects 3-rd party Python on CI.

@mati865 mati865 marked this pull request as draft October 15, 2020 18:43
@mati865
Copy link
Collaborator Author

mati865 commented Oct 15, 2020

Okay using already existing compiler-rt is the only way to have profiler library. I'll update PR later along with few more tweaks to PKGBUILD.

BTW maybe we should consider splitting this PKGBUILD into separate packages?

@oscarfv
Copy link
Contributor

oscarfv commented Oct 16, 2020

BTW maybe we should consider splitting this PKGBUILD into separate packages?

I looked into this on the past and realized that the build and maintenance would become much more complex without any substantial benefit.

@mati865 mati865 force-pushed the llvm-11 branch 2 times, most recently from 73caa0a to d54e0ce Compare October 16, 2020 17:17
@mati865
Copy link
Collaborator Author

mati865 commented Oct 18, 2020

Okay it works but maybe we should uninstall the other Python for other packages?

BTW maybe we should consider splitting this PKGBUILD into separate packages?

I looked into this on the past and realized that the build and maintenance would become much more complex without any substantial benefit.

It'd make easy version bumps a bit more complicated (that can be solved with script) but big upgrades would be easier to work with. Also it'd allow using faster Ninja instead of Make.

@mati865 mati865 marked this pull request as ready for review October 18, 2020 19:08
@mati865
Copy link
Collaborator Author

mati865 commented Oct 19, 2020

Removed shared linking from the description, I accidentally disabled at some point and re-enabling it now causes DEP violation. I guess we have to recompile libcxx first which is not really possible with monolithic PKGBUILD.

@mati865 mati865 mentioned this pull request Oct 20, 2020
@lazka lazka merged commit 5d90549 into msys2:master Oct 20, 2020
@mati865 mati865 deleted the llvm-11 branch October 20, 2020 16:21
@lazka
Copy link
Member

lazka commented Oct 21, 2020

For some reason this fails in the autobuilder:

2020-10-21T06:58:19.6663357Z [  9%] �[32mBuilding ASM_MASM object projects/openmp/runtime/src/CMakeFiles/omp.dir/z_Windows_NT-586_asm.asm.obj�[0m
2020-10-21T06:58:19.6733194Z [  9%] �[32m�[1mLinking C static library ../../../../lib/libPollyISL.a�[0m
2020-10-21T06:58:19.7320725Z UASM v2.50, Jan  8 2020, Masm-compatible assembler.
2020-10-21T06:58:19.7328718Z Portions Copyright (c) 1992-2002 Sybase, Inc. All Rights Reserved.
2020-10-21T06:58:19.7474819Z Source code is available under the Sybase Open Watcom Public License.
2020-10-21T06:58:19.7506188Z 
2020-10-21T06:58:19.7537191Z make[2]: *** [projects/openmp/runtime/src/CMakeFiles/omp.dir/build.make:472: projects/openmp/runtime/src/CMakeFiles/omp.dir/z_Windows_NT-586_asm.asm.obj] Error 1
2020-10-21T06:58:19.7537981Z Error A2104: No filename specified.
2020-10-21T06:58:19.7566461Z make[1]: *** [CMakeFiles/Makefile2:36325: projects/openmp/runtime/src/CMakeFiles/omp.dir/all] Error 2
2020-10-21T06:58:19.7574113Z make[1]: *** Waiting for unfinished jobs....

https://github.com/msys2/msys2-autobuild/runs/1285100942?check_suite_focus=true

@mati865
Copy link
Collaborator Author

mati865 commented Oct 21, 2020

PR builder did succeed 🤔
Either #7157 was the missing part or another update broke the build.

@lazka
Copy link
Member

lazka commented Dec 3, 2020

drive by question: that libunwind depends on gcc is probably not on purpose, right?

@mati865
Copy link
Collaborator Author

mati865 commented Dec 3, 2020

Yeah, libunwind really depends only on the system libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants