fix(typescript): support typescript 5.0 #1566
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84f3ac8:
|
| @@ -57,7 +57,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ts: ['4.4', '4.5', '4.6', '4.7', '4.8', '4.9'] | |||
| ts: ['4.4', '4.5', '4.6', '4.7', '4.8', '4.9', '5.0'] | |||
There was a problem hiding this comment.
do we have a set number of versions to support? should we pop off the 4.4?
There was a problem hiding this comment.
@mattcosta7, yes, I'd drop 4.4 in this change.
broaden typescript support to include 5.0
mattcosta7
force-pushed
the
typescript-5-support
branch
from
be52a5b to
b52c364
Compare
There was a problem hiding this comment.
Thanks for adding TS 5 support, @mattcosta7!
Could you please add a typings test for ts 5 in here as well? This way we will have a bit more assurance that the library compiles and runs correctly with that ts version. Thanks.
sure thing - probably won't have time until later today or tomorrow though! |
|
think that should do it 84f3ac8 |
|
when can we expect a release ? |
Released: v1.1.1 🎉This has been released in v1.1.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
fixes #1567
broaden typescript support to include 5.0
not sure if this is best a 'fix' 'chore' or 'feature' commit, since it's not really changing anything, besides broadening support.
Opted for fix to keep the version change a patch, but open to changing that!
tsupdoesn't currently have a peer range including 5.0.x, however things seem to build correctly - not sure if we need to wait for tsup to update first, given build/test passes here