add openDrawer and openDrawerOnSmallScreens method on mdl-layout #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, thx for your contribution. please add some tests to your pr. thx. |
* openDrawer() * closeDrawer() * openDrawerOnSmallScreens() * toggleDrawer() from opened state * toggleDrawer() from closed state
|
Added tests for openDrawer() and openDrawerOnSmallScreens() |
|
hi thx a lot. will be released as @angular-mdl/core@4.0.7 in a few minutes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdl-layout.component only have closeDrawer(), toggleDrawer() and closeDrawerOnSmallScreens().
Drawer open related methods are missing.
Of cause we would operate drawer to open with public isDrawerVisible and toggeDrawer() etc.
But I think better adding openDrawer() and openDrawerOnSmallScreens() to mdl-layout.coponent.