Fixed misprint with menu components array #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed missprint with menuComponents array
|
@mseemann Could you please take a look at this PR? |
|
@AVykhrystyuk thx! will be in the next release. |
|
@mseemann Thanks. May I know some approximate date for the next release? |
|
the next release will be 5.0.0. There are some breaking changes that needs some more time. If you need this urgent, please create a PR against the angular4 branch. after that i can publish a 4.0.9 version. thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently destroyed menu components are not removed from
MdlMenuRegistydue to misprint inArray.prototype.splice.This leads to continuous calls of
MdlMenuComponent.hide()inMdlMenuRegisty.hideAllExcept()for menu components that are already destroyed.In my use case this leads to TypeError: Cannot read property 'toArray' of undefined when user clicks on any alive menu drop-down component.
This PR should fix the misprint so the components are removed correctly from
MdlMenuRegisty.Commit summary:
Can not find 'protractor' typings