Fix issue with resolving camera view in Frame Processor #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for your PR! LGTM 🔥🖤 |
|
@mrousavy Can a new version be released as soon as possible? Thanks. |
|
Yes @adamlbailey, I'll try to get to that as soon as I can! |
4 tasks
4 tasks
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
* Fix issue with resolving camera view from frame processor for react-native Modal * Add missing import of UIManagerHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When a modal is used the Camera view is not in the hierarchy of the current activity.
Therefore we utilize the global React Native View registry to resolve the view instance.
Changes
Changed way how Camera view is resolved
Tested on
Android 12
Related issues
Fixes #810