Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dap): validate custom DAP client configs #670

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(dap): validate custom DAP client configs #670

merged 1 commit into from
Jan 28, 2025

Conversation

mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Jan 28, 2025 •
edited
Loading

If users add custom configs with missing fields, they get a cryptic error.

This should display a better error message.

@github-actions GitHub Actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@mrcjkb mrcjkb merged commit ca7e678 into master Jan 28, 2025
8 checks passed
@mrcjkb mrcjkb deleted the mj/push-zxwwnkormxws branch January 28, 2025 17:04
@mrcjkb mrcjkb mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrcjkb