This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
We need to bring back loading states while pages complete rendering #2434
Milestone
Comments
Thanks for such detailed feedback. |
lmorchard
added a commit
to lmorchard/testpilot
that referenced
this issue
May 16, 2017
…ine React styles - Also inject content-security-policy header in the local dev server - See also: facebook/react#5878 (comment) Issue mozilla#2434
Just submitted a PR to reproduce my last comment on local dev, and change CSP to allow inline styles because ugh. |
lmorchard
added a commit
to lmorchard/testpilot
that referenced
this issue
May 16, 2017
…ine React styles - Also inject content-security-policy header in the local dev server - See also: facebook/react#5878 (comment) Issue mozilla#2434. Fixes mozilla#2432.
Ah, looks like that was #2432 - which turns out to be CSP related, not time related, and won't be fixed by a loading delay |
This was referenced May 16, 2017
fzzzy
added a commit
to fzzzy/testpilot
that referenced
this issue
May 16, 2017
Remove the inline styles on the experiment cards, by creating experiments.css ahead of time from the yaml files
fzzzy
added a commit
to fzzzy/testpilot
that referenced
this issue
May 16, 2017
Remove the inline styles on the experiment cards, by creating experiments.css ahead of time from the yaml files Remove the inline styles from the experiment details pages as well. Remove unsafe-inline from the CSP again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There may be some down-the-road workarounds here, but there appear to be several issues related to removing the Loading state as page components get built. To name a few:
There are a lot of small cuts here but the sum total is that the site w/o loading components has significant jank associated with toggling state that damages the overall experience of the site.
Until we can resolve these conflicts without loaders we should bring them back.
The text was updated successfully, but these errors were encountered: