Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bring back aarch64-unknown-linux-musl #1926

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

quad
Copy link

@quad quad commented Oct 30, 2023

This reverts commit 841fb0b.

@quad quad changed the title Revert "Disable aarch64-unknown-linux-musl" ci: bring back aarch64-unknown-linux-musl Oct 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e911999) 29.70% compared to head (1a50f59) 29.60%.
Report is 15 commits behind head on main.

❗ Current head 1a50f59 differs from pull request most recent head ba6e114. Consider uploading reports for the commit ba6e114 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1926      +/-   ##
==========================================
- Coverage   29.70%   29.60%   -0.11%     
==========================================
  Files          50       50              
  Lines       18022    17768     -254     
  Branches     8703     8530     -173     
==========================================
- Hits         5354     5260      -94     
+ Misses       7491     7413      -78     
+ Partials     5177     5095      -82     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quad quad force-pushed the ssr/20231031/bring-back-aarch64-linux branch 2 times, most recently from ba6e114 to 97cedcb Compare October 30, 2023 16:36
@quad quad force-pushed the ssr/20231031/bring-back-aarch64-linux branch from 97cedcb to 95b3913 Compare October 30, 2023 16:44
@quad quad marked this pull request as ready for review October 30, 2023 16:46
@quad
Copy link
Author

quad commented Oct 30, 2023

@sylvestre @Xuanwo This PR is ready to go! 🚀

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sylvestre
Copy link
Collaborator

I will merge it in the next Few hours and make a new release

@sylvestre sylvestre merged commit ab94306 into mozilla:main Oct 30, 2023
@quad
Copy link
Author

quad commented Oct 31, 2023

@sylvestre I eagerly await a new release! Unsurprisingly, we use the arm64 builds, so we're stuck on 0.5.4 until it's out! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants