Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert OpenDAL bump to fix the hang while connecting ghac #1790

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jun 4, 2023

This PR will address #1789

The root cause is still not found, but I'm confirmed that it's OpenDAL's issue. This PR will fix that and we need a new release for 0.5.3.

Xuanwo added 2 commits June 4, 2023 17:52
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (f9cebc0) 29.45% compared to head (132aae6) 29.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   29.45%   29.44%   -0.02%     
==========================================
  Files          49       49              
  Lines       17713    17713              
  Branches     8538     8551      +13     
==========================================
- Hits         5218     5216       -2     
  Misses       7345     7345              
- Partials     5150     5152       +2     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 5f0b567 into mozilla:main Jun 4, 2023
@Xuanwo Xuanwo deleted the fix-ghac-hang branch June 4, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants