Replace lazy_static with once_cell #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
==========================================
- Coverage 29.44% 29.43% -0.02%
==========================================
Files 49 49
Lines 17594 17609 +15
Branches 8493 8494 +1
==========================================
+ Hits 5181 5183 +2
- Misses 7257 7317 +60
+ Partials 5156 5109 -47
☔ View full report in Codecov by Sentry. |
tottoto
force-pushed
the
replace-lazy-static-with-once-cell
branch
from
2eaab66 to
1aec4c6
Compare
Xuanwo
approved these changes
May 8, 2023
|
Thanks! |
liskin
reviewed
Jun 14, 2023
| static ref CACHED_CONFIG: Mutex<Option<CachedFileConfig>> = Mutex::new(None); | ||
| } | ||
| static CACHED_CONFIG_PATH: Lazy<PathBuf> = Lazy::new(CachedConfig::file_config_path); | ||
| static CACHED_CONFIG: Lazy<Mutex<Option<CachedFileConfig>>> = Lazy::new(|| Mutex::new(None)); |
There was a problem hiding this comment.
Mutex::new is const since Rust 1.63 and #1702 bumped sccache's MSRV to 1.64 three months ago so this can be simplified further I think 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
lazy_staticwithonce_cellasonce_cellis without macros and it will go to standard library.