-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump msrv to 1.65.0 #1743
Bump msrv to 1.65.0 #1743
Conversation
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
+ Coverage 29.14% 29.23% +0.09%
==========================================
Files 49 49
Lines 17456 17456
Branches 8471 8460 -11
==========================================
+ Hits 5087 5103 +16
+ Misses 7297 7245 -52
- Partials 5072 5108 +36
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the new clippy lint that strikes, otherwise, if that's between openssl and no openssl, I'd be very much in favor of bumping msrv
Sure! Regarding the openssl, I've figured out how to avoid it in sccache and I will soon update PR #1742 thanks to the cachepot PR you provided @drahnr |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
ci/freebsd has spuriously failed again, so it should be ok to merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
To fix #1742
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com